[chore/bugfix] Demote 'failed' inbox forwarding to warn log rather than error return #1892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, side effect actor inbox forwarding unfortunately handles some of the necessary side effects of creating activities and whatnot (see #1891). However, this often causes annoying errors to pop up, especially when doing things like receiving Likes from Misskey instances that target statuses our instance doesn't know about yet. This causes a db error which then results in a 500 being returned to the remote server.
As a temporary workaround before we fix the actual issue, we can at least tone down the error message here so that it doesn't return 500 to the caller, and just does a warn log instead, since it's unlikely that failed inbox forwarding indicates an actual error.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.