Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore/bugfix] Demote 'failed' inbox forwarding to warn log rather than error return #1892

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

Currently, side effect actor inbox forwarding unfortunately handles some of the necessary side effects of creating activities and whatnot (see #1891). However, this often causes annoying errors to pop up, especially when doing things like receiving Likes from Misskey instances that target statuses our instance doesn't know about yet. This causes a db error which then results in a 500 being returned to the remote server.

As a temporary workaround before we fix the actual issue, we can at least tone down the error message here so that it doesn't return 500 to the caller, and just does a warn log instead, since it's unlikely that failed inbox forwarding indicates an actual error.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst marked this pull request as ready for review June 14, 2023 12:56
@tsmethurst tsmethurst merged commit 827cc4d into main Jun 14, 2023
@tsmethurst tsmethurst deleted the inbox_forwarding_warn branch June 14, 2023 13:08
tsmethurst added a commit that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant