Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-mp4 to latest commit #2028

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

theSuess
Copy link
Contributor

Description

This updates the go mp4 lib to include abema/go-mp4#135 which enables support for probing mp4 files with a co64 box instead of a stco box. This is the case for videos recorded on newer android devices.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

This adds support for probing mp4 files with a co64 box instead of an stco box,
which is the case for videos recorded on newer android devices.
@tsmethurst tsmethurst merged commit 98c2b8f into superseriousbusiness:main Jul 27, 2023
@tsmethurst
Copy link
Contributor

Oh thank you, nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants