Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] allow store smaller PNG image than 261 bytes (#2263) #2298

Merged

Conversation

KEINOS
Copy link
Contributor

@KEINOS KEINOS commented Oct 25, 2023

Description

This PR closes #2263:

This fix avoids the "unexpected EOF" error during store when the input image is smaller than 261 bytes. This is the size of the header used to detect the image type.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@KEINOS KEINOS changed the title chore: add test of golden cases before fix of #2263 [bugfix] allow store smaller PNG image than 261 bytes (#2263) Oct 25, 2023
@KEINOS KEINOS marked this pull request as ready for review October 25, 2023 12:31
@tsmethurst
Copy link
Contributor

Great stuff, thank you very much!

@tsmethurst tsmethurst merged commit 27f4659 into superseriousbusiness:main Oct 25, 2023
@KEINOS KEINOS deleted the fix-2263-err-on-small-img branch October 25, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Bad request when trying to use very small avatars/banners
2 participants