[bugfix] Allow blocked accounts to show in precise search #2321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the search implementation to allow showing accounts in results that have been blocked by the searcher, but ONLY if the search query is specific enough that it's unmistakeably the blocked account that's being searched for.
Previously we were a bit too strict in our visibility checking, so if you blocked someone and wanted to unblock them, you couldn't just search for them and click unblock, you had to either go through your notifications, or mentions, or whatever, looking for the person so you could open their profile and click unblock on them.
Blocked accounts will still not be shown in more general search results.
Also does a little quality-of-life stuff:
closes #2255
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.