-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add support for polls + receiving federated status edits #2330
[feature] add support for polls + receiving federated status edits #2330
Conversation
Holy crap! It's arrived! Will get my reviewing glasses on (imagine opera glasses held on a stick while I peer at your code discerningly from up on the balcony). |
5bc0e3f
to
5e7f53f
Compare
…atuses.local column
b6125d2
to
35682c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work, well done! I have some small comments but no serious changes! Can't wait to try this out!
…o the same for the status ID
…re poll after vote returns incremented version
…types for sqlite / postgres separately
…tes on vote in local poll
Can I please ask if this implementation will be able to get polls from older posts (from other instances), or only from the moment we upgrade? |
It will get polls from older posts too the next time you open that post in your client :) |
Hey! I'm confused about something: does this PR enable seeing edits on federated posts? It seems that at least image descriptions are not updating for me :) |
Description
Adds support for the following features:
Closes:
#1579
#1990
Continuing where #2237 was closed, but with less horrific commit history. (I lost count of the number of rebases on that PR, it was very long-running). Is currently based upon #2329 so will rebase from that when it is merged.
TODO:
docs on polls from an AP perspectivefor another PR!handling federation side effects on poll voteinserting poll on client API status createpoll scheduler + required side-effectsadd necessary database migrationfinish writing docs for code commentsside-effects of local vote in local pollside-effects of local vote in remote pollside-effects of remote vote in local pollfinal fixups (many i'm sure)poll database testspoll vote database testspoll processor testpoll vote processor testAS status w/ poll testsAS poll vote testsNotes:
Checklist
go fmt ./...
andgolangci-lint run
.