-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Media attachment placeholders #2331
Conversation
very excited for this one tbqh 👀 |
5ec8e28
to
bf7ae4e
Compare
@NyaaaWhatsUpDoc Ready to review now I reckon! |
internal/media/test/Frantz-Fanon-The-Wretched-of-the-Earth-1965.pdf
Outdated
Show resolved
Hide resolved
@tsmethurst Phanpy's dev suggested using a This issue is mostly because right now the text of this placeholder is very easily confused with the actual text of the post itself (happened to me). |
yes, some kind of styling would be useful. Also, I don't know if it is possible to add a reason for the attachment not loading (explicit or an error code), so I could blame the poster and not my GtS instance 😸 thank you |
Description
This pull request makes the following changes:
unknown
type in the database, without caching the data in storage.Cache of unknown media types will be reattempted next time the status to which the media is attached gets refreshed (2hr cooldown). This means that as we add support for more types, it will be possible to refresh old statuses and have the new media show up properly.
The note added to the status when serialized via the API uses the html
<aside>
tag to indicate that this is supplementary information:Screenshots of a status reply containing one processable type and two unknown types.
On the web:
On pinafore (note, the testrig instance is
localhost:8080
):closes #1013
closes #2175
Relates to (and partially addresses) #2313
Relates to (and partially addresses) #2308
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.