Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore/frontend] Refactor status templates slightly, put polls behind CWs if present #2419

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request tidies up our templates a bit:

  • Produce more consistently laid out HTML.
  • Separate status media attachments into a separate template for readability.
  • Put polls inside the CW instead of having them outside (since poll questions can also be sensitive ofc).
  • Indicate when a poll is multiple choice.

Closes #2393

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst changed the title Poll cw [chore/frontend] Refactor status templates slightly, put polls behind CWs if present Dec 5, 2023
@tsmethurst tsmethurst merged commit dacfd41 into main Dec 5, 2023
@tsmethurst tsmethurst deleted the poll_cw branch December 5, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore/frontend] Little poll web view updates before 0.13.0 is out
1 participant