Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix poll total vote double count #2464

Conversation

Sentynel
Copy link
Contributor

Description

In the case where the requesting user had voted in a poll, we would double count their votes towards the overall count of votes. This happens because we calculate a vote count of our own votes in case we can't see all the votes, but this isn't cleared before processing in the case where we can see all the votes, resulting in a double count.

closes #2463

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

oh eagle eye! nice catch!

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 07bd848 into superseriousbusiness:main Dec 16, 2023
2 checks passed
tsmethurst pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Own votes double counted towards total number of votes in poll
2 participants