[chore] Harden up boolptr logic on Accounts, warn if not set #2544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds nil ptr checks in the account to api account typeutil conversion functions, which should unclog #2527 and #2514.
Unfortunately, I couldn't find the issue that was causing those ptrs to be nil in the first place, or even replicate the bug on the testrig. Some warning logs have been added to the nil ptr checks so we can hopefully gather some info on when this happens, while working around the bug.
Also adds a bunch of tests for a typical Honk account, in an attempt to reproduce the bug. The reproduction failed, but the tests are still good to have.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.