-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add oauth token authentication workflow #2655
[docs] Add oauth token authentication workflow #2655
Conversation
Overall this looks pretty great. I have some small stylistic/markup changes and once those get resolved I think this should be good to go! You can see the rendered result here: https://gotosocial--2655.org.readthedocs.build/en/2655/api/authentication/. Once you push changes it'll automatically rebuild so you can see the effect of the changes. |
sweet ... thanks for these. i will try and have them done today |
No worries, it's the weekend! We'll be here all of next week 😉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving the comments! There's one with a wrong header name and after that I think we're good to go.
Co-authored-by: Daenney <daenney@users.noreply.github.com>
done. surprised i missed that especially since i caught a few other typos earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for this!
my pleasure. i've been looking for the opportunity to contribute for a while. |
I'll leave it open for a day or two so the rest of the team has the opportunity to go through it too. If it doesn't get merged by anyone else I'll click the button on Wednesday. |
This is looking good :) I'll have a proper look through it this afternoon. Thanks for doing this! Linking this issue because it's relevant: #2421 |
Alright, added a last couple suggestions, then I think this is good to go :) |
Merged it! :) Thank you very much for this! |
It was my pleasure! I love this project! |
Add the api authentication workflow to the documentation
This pull request adds the api authentication workflow to the documents and addresses #1135.
Closes: #1135
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.