Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[performance] cached oauth database types #2838

Merged
merged 8 commits into from
Apr 15, 2024
Merged

[performance] cached oauth database types #2838

merged 8 commits into from
Apr 15, 2024

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Updates our oauth server client + token store code to rely on our database caches.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as draft April 15, 2024 11:29
@tsmethurst
Copy link
Contributor

Looks good! Squerge whenever you're happy with it.

@NyaaaWhatsUpDoc
Copy link
Member Author

@tsmethurst i just realized we don't have a unique constraint on our gtsmodel.Token{} "code", "refresh", "access" fields, do you think it's worth adding these?

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review April 15, 2024 11:55
@tsmethurst
Copy link
Contributor

Mmm it's probably fine without tbh, especially since altering a table to add constraints is a bit of a faff in sqlite.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit f79d50b into superseriousbusiness:main Apr 15, 2024
2 checks passed
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@NyaaaWhatsUpDoc @nyarla
[performance] cached oauth database types (superseriousbusiness#2838)
1443fe5 
* update token + client code to use struct caches

* add code comments

* slight tweak to default mem ratios

* fix envparsing

* add appropriate invalidate hooks

* update the tokenstore sweeping function to rely on caches

* update to use PutClient()

* add ClientID to list of token struct indices
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@NyaaaWhatsUpDoc @nyarla
[performance] cached oauth database types (superseriousbusiness#2838)
92b5bbb 
* update token + client code to use struct caches

* add code comments

* slight tweak to default mem ratios

* fix envparsing

* add appropriate invalidate hooks

* update the tokenstore sweeping function to rely on caches

* update to use PutClient()

* add ClientID to list of token struct indices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmethurst tsmethurst tsmethurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NyaaaWhatsUpDoc @tsmethurst