Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix incorrect field name for status source, add helpful message #2854

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Apr 18, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

I misnamed a field name in the status source PR, so this fixes that. Also adds a helpful message returning status source (which is used for edits), indicating to the user that they won't be able to resubmit the changed source as an edit.

The little message shown to the user after they've clicked "edit" and they get the original post text open in their client looks like this:

image

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

what is this swagger.yam

where can i get some yam

@tsmethurst
Copy link
Contributor Author

You rascal. Fixed it!

@NyaaaWhatsUpDoc
Copy link
Member

You rascal. Fixed it!

oh I'M the rascal here, huh??

@tsmethurst
Copy link
Contributor Author

Confirmed rascal by a jury of your peers.

@tsmethurst tsmethurst merged commit b7c629a into main Apr 18, 2024
3 checks passed
@tsmethurst tsmethurst deleted the status_source_fix branch April 18, 2024 11:22
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…age (superseriousbusiness#2854)

* [bugfix] Fix incorrect field name for status source, add helpful message

* swagger

* yyammm
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…age (superseriousbusiness#2854)

* [bugfix] Fix incorrect field name for status source, add helpful message

* swagger

* yyammm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants