Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Self-serve email change for users #2957

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jun 3, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request implements self-serve email address changes, so that admins don't have to manually change people's addresses in the database anymore.

To support this, adds two new endpoints: GET /api/v1/user and POST /api/v1/user/email_change.

UI preview of the user email change thingy in the settings panel

Closes #2373

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst marked this pull request as ready for review June 5, 2024 12:23
@NyaaaWhatsUpDoc
Copy link
Member

a few comments but otherwise looks good :)

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit bcda048 into main Jun 6, 2024
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the user_email_change branch June 6, 2024 13:43
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
* [feature] Email change

* frontend stuff for changing email

* docs

* tests etc

* differentiate more clearly between local user+account and account

* populate user
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
* [feature] Email change

* frontend stuff for changing email

* docs

* tests etc

* differentiate more clearly between local user+account and account

* populate user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Email change mechanism
2 participants