-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Rain Forest Theme #3021
Conversation
new green-ish theme
oh this is a wonderful theme / PR, thank you! though i'm gonna leave actual review of this to @tsmethurst who knows CSS / has more colour-based opinions than i |
thank you @NyaaaWhatsUpDoc 🤗 🤦 forgot to commit latest minor changes before making PR (but already in the «preview»)
and retired the «border» in stats these are minor changes to reflect water/wood/earth... used in user stats, post's data and stats, bio background. I would later add it I will make a new PR |
This looks nice, thanks for doing it ^_^ The only issue I can see so far is that the text + background on the "Show More" button doesn't meet WCAG contrast standards. Normally when writing a new theme I do it in firefox and periodically use the "accessibility" tab in the console to check for contrast issues. If you can fix that, and add the other changes you wanted to do, this will be mergeable I think :) Btw, you might also consider styling polls in the same vein as the rest of the theme, but not a big deal :P |
thank you @tsmethurst yes, that button in an issue to solve 👍 , poor contrast. I'll make other minor adjustments, try to style polls and then make a new PR here. Thank you. |
changes since *draft* version: * lighter green for links (better contrast ratio) * higher «show more/less» button contrast * post's border thinner and darker (papaya) * lighter "glow" (shadow) * button has not shadow * polls themed (dark blues) * papaya scrollbar * code box border thinner (not rounded) * accesibility tested in firefox dev options (no issues) * release ready v1.0
delete "theme" folder and move to "themes"
I hate github BTW 😅 excuse me if I eventually have moved around some files/folders, I've tried my best to bring here version 1.0 with latest changes. |
Thanks for this! |
🦥 I missed a green-ish theme to select from default options
From wikipedia sloth:
A life worth living, if you ask me.
So searched online for some rain forest color palette to inspire this GtS theme.
code
andquote
styled just to make it more distinct from regular posts and relate to other elements like wood/water/earthI think all sections have good contrast ratio, also increased visibility in user profile section.
Seriously considered top header border with solid white color as would make it better for most header pictures, but wanted to keep the sunny tint
You can test with custom css section or just creating a
sweet-home.css
file in ./web/assets/theme/` folder, restart gotosocial and select from user control panel.Or you can preview it here
Enjoy! and please consider to add this or any variation of green theme. Thank you.
Edit
I did not commit minor latest changes as published in #3021 (comment)