-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] persist worker queues to db #3042
Merged
tsmethurst
merged 22 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:feature/persist-worker-queues-to-db.2
Jul 30, 2024
Merged
[feature] persist worker queues to db #3042
tsmethurst
merged 22 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:feature/persist-worker-queues-to-db.2
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daenney
reviewed
Jun 26, 2024
NyaaaWhatsUpDoc
force-pushed
the
feature/persist-worker-queues-to-db.2
branch
from
July 12, 2024 11:48
b462cd9
to
5f07dd1
Compare
…es from database on startup
…er task persistence
NyaaaWhatsUpDoc
force-pushed
the
feature/persist-worker-queues-to-db.2
branch
from
July 30, 2024 11:34
5f07dd1
to
984fe25
Compare
Nice one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Persists the state of worker queues to the database on shutdown, and attempts to recover them from database on startup.
Before this is reviewed (or even has a readable diff), it depends on both #3000 and #2989.
This replaces #3019 as frankly trying to rebase that thing was horrible, it was easier to just cherry-pick the stream of commits ontop of main.
Checklist
go fmt ./...
andgolangci-lint run
.