Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] more filetype support! #3107

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

This updates our code wrapping ffprobe / ffmpeg in the media processor to support more of the file types that the previously mentioned programs support decoding / encoding. This also updates the instance supported media mimetypes list to better reflect what we do support now (woohoo!), reduces the complexity of code in the media processing pipeline so audio / image / video types share as much code as possible, and converts the result output of ffprobe to a more useable data format.

Oh another nice little change, it tells ffprobe to use compact-json output so it reduces need for outputting so much whitespace. Not a massive change but i love ones like these as it's essentially free efficiency boost :)

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit de45c0b into superseriousbusiness:main Jul 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant