Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] incorrect /api/v_/instance domain uri fields #3477

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

closes #3467

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Looks good. We should probably think about removing account_domain at some point then since it turns out it's superfluous.

@NyaaaWhatsUpDoc
Copy link
Member Author

Looks good. We should probably think about removing account_domain at some point then since it turns out it's superfluous.

yeah i was unsure of that... at the moment it can be used to tell if a separate account_domain exists, but then i suppose they can already tell that as they know the host to be dialling the instance endpoint :p

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit d8a8386 into superseriousbusiness:main Oct 22, 2024
2 checks passed
@tsmethurst
Copy link
Contributor

Yeah indeed 🤔 Could you make an issue for removing it? We just need to investigate what uses it (can't remember why we added it) and change it to use uri instead, basically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] /api/v*/instance domain and uri properties conflict with Mastodon’s usage of those property names
2 participants