Log when listening #350
Merged
Log when listening #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `gotosocial server` with the default configuration will try to bind to :80 and listen for letsencrypt challenges, which will fail if running as non-root (w/o capabilities), or if eg. nginx hogs the port. When that happens, this should make it more obvious what's wrong.
Always nice not to have to guess. Also feels more consistent than just doing it for the letsencrypt endpoint.
liclac
force-pushed
the
log-when-listening
branch
from
42a58fc to
36a6b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a bit confused when trying to start
gotosocial server, because it was failing to bind to:80, when I was asking it to bind to:8080. Turns out that's the let's encrypt port!Since this will fail when running as non-root (without
CAP_NET_ADMIN, at least), or if something like nginx is already hogging that port, we should probably make the error a bit more obvious, and add some logging for good measure.(Maybe it's just me, but I like it when software tells me when it's opening ports and stuff.)