[fix] Make postgres connections magically work in common setups #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liclac
force-pushed
the
database-magic
branch
from
59a6055 to
ff456f0
Compare
tsmethurst
changed the title
The pgx code actually goes to great lengths to make postgres connections Just Work(tm) out of the box, including supporting `~/.pg_service.conf`, SSL certificates, UNIX sockets if it can find a socket at a common path, and falling back to TCP to localhost if not. (On Windows, it won't try to use UNIX sockets, but will read credentials from %appdata% as is standard over there.) By applying our flags as overrides only when they're specified, database connections should Just Work(tm) anywhere `psql gotosocial` does.
liclac
force-pushed
the
database-magic
branch
from
ff456f0 to
09e1a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, this changes the default database name to
gotosocial; dumping our tables into the systempostgrestable probably shouldn't be the default.Second, I started reading the
pgxcode, and it actually goes to great lengths to make postgres connections work out of the box:~/.pg_service.confand TLS client certificates in standard paths.localhost.Which means that if we just unset our default credentials, and apply them only if actually set in our config, the database connection should Just Work(tm) anywhere
psql gotosocialwould.https://github.com/jackc/pgconn/blob/a123e5b4e575b5eb3c68ae4ab87c508d341242df/defaults.go
https://github.com/jackc/pgconn/blob/a123e5b4e575b5eb3c68ae4ab87c508d341242df/defaults_windows.go