Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add support for clients editing statuses and fetching status revision history #3628

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

  • adds PUT /api/v1/statuses/:id method to support local users editing their own statuses
  • updates the existing status history endpoint to return revision history for statuses (where possible)
  • adds a slew of new tests for the local status edit endpoint

WIP:

  • finish commenting code, especially the tests (and possibly refactor to share a bunch of the status / edit validation)
  • possibly add documentation?

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

tsmethurst commented Dec 19, 2024

Bloody good work here! Honestly I think you should squerge it whenever you're happy with it, I've got no notes. (Edit OK one or two notes)

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc force-pushed the feature/handle-client-status-edits branch from 6adbfce to a6e3b97 Compare December 23, 2024 13:20
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review December 23, 2024 15:06
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit fe8d5f2 into superseriousbusiness:main Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants