Skip to content

[bug] Fix OIDC users requiring second approval #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

tsmethurst
Copy link
Contributor

This PR updates some of the OIDC logic in order to pre-approves users + accounts created via OIDC.

Rationale as follows:

// Since this user is created via oidc, which has been set up by the admin, we can assume that the account is already
// implicitly approved, and that the email address has already been verified: otherwise, we end up in situations where
// the admin first approves the user in OIDC, and then has to approve them again in GoToSocial, which doesn't make sense.
//
// In other words, if a user logs in via OIDC, they should be able to use their account straight away.

Closes https://github.com/superseriousbusiness/gotosocial/issues/357

@tsmethurst tsmethurst merged commit 18e7537 into main Jan 31, 2022
@tsmethurst tsmethurst deleted the pre_approve_oidc_users branch January 31, 2022 15:03
@superseriousbusiness superseriousbusiness locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Accounts created via OIDC shouldn't require approval
1 participant