[feature] Basic config validation #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
once the full Config is validated, we can put it into the systemd unit's reload step, and fail with an error there, instead of reloading a broken Config and then failing to start |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic config validation for
hostandprotocol, and opens the door for more config validation in future.The validation is performed only for CLI commands, in the
preRunfunction, and it can be disabled for commands that shouldn't validate config (like printed collated command to stdout as ingotosocial debug config).Also adds test for some of the validation logic.
This was inspired by @ForestJohnson's earlier PR here: #399
closes #495