[bugfix] Clean up boosts of status when the status itself is deleted #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss/gotosocial into status_reblog_cleanup
tsmethurst
changed the title
tsmethurst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for cleaning up boosts of a status from the database when the status itself has been deleted. This should prevent issues like #477 where a user's timeline could break if a boost was put into it for a status that was subsequently removed from the database.
The PR also does a bit of tidying up of some code duplication in the processor, by moving the logic for wiping out a status into the fromcommon file.
closes #477