[bugfix] Fix HTML escaping in instance title #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's no longer used outside the text package so this makes it less confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where text was being HTML escaped in instance titles during a PATCH to /api/v1/instance.
To do this, the PR rearranges some of the text formatting and sanitization logic. The
textpackage now no longer exposes the RemoveHTML function, which was being used too much, and instead renames SanitizeCaption to SanitizePlaintext, and makes this function more widely used in places where plaintext and not HTML is required.It also adds some tests for instance patching, to prove that this fixes the issue ;)