[:frog:] Profile pages #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deployed on https://gts-dev.pixie.town/@f0x
|
f0x52
force-pushed
the
frogend-profile-pages
branch
from
56ed315 to
84f9f54
Compare
f0x52
commented
Jun 19, 2022
| <img src="{{.account.Header}}"/> | ||
| <img | ||
| src="{{.account.Header}}" | ||
| alt="{{if .account.DisplayName}}{{.account.DisplayName}}{{else}}{{.account.Username}}{{end}}'s header" |
There was a problem hiding this comment.
This will be filled when users have the ability to describe their avatar/header
| {{ end }} | ||
| </div> | ||
| <div class="basic"> | ||
| <a href="{{.account.Avatar}}" class="avatar"><img src="{{.account.Avatar}}"></a> | ||
| <a href="{{.account.Avatar}}" class="avatar"><img src="{{.account.Avatar}}" alt="{{if .account.DisplayName}}{{.account.DisplayName}}{{else}}{{.account.Username}}{{end}}'s avatar"></a> |
| @@ -1,4 +1,4 @@ | |||
| <a href="{{.Account.URL}}" class="avatar"><img src="{{.Account.Avatar}}"></a> | |||
| <a href="{{.Account.URL}}" class="avatar"><img src="{{.Account.Avatar}}" alt=""></a> | |||
There was a problem hiding this comment.
initial feedback i got was to not add it to every status entry, since it'd get rather repetitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building upon restructure in #634