[feature] S3 support #674
Merged
[feature] S3 support #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this saves a lot of bandwith as the files are fetched from the object store directly
|
Gonna review this in the coming days, thank you for all your hard work! |
|
FYI: I've now also verified functionality with scaleway and backblaze, so I feel confident that this supports the majority of S3 providers |
tsmethurst
reviewed
Jun 28, 2022
also adds license header to the storage package
HTTP 302 Found is the best fit, as it signifies that the resource requested was found but not under its presumed URL 307/TemporaryRedirect would mean that this resource is usually located here, not in this case 303/SeeOther indicates that the redirection does not link to the requested resource but to another page
|
Alright, i discussed it with the other devs, and this looks good! So I'm gonna go ahead and merge it. Thank you so much for all your hard work! :) |
|
Wow, this works great (running it on Ceph) and just the way I wanted to build it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #308
This adds S3 support by abstracting the storage driver in a new package
internal/storage. When accessing an asset via S3, a signed resource URL is generated and returned as an HTTP Redirect. This helps to prevent hotlinking while still reducing load on the server.I've tested it against MinIO and will continue tests on other providers tomorrow (Backblaze and Scaleway as they offer free tiers).
I also might want to refactor the
Contenttype into an interface to have more type safety but wanted to create this PR to get early feedback if this approach is usable