Blocklist import #77
Merged
Blocklist import #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds importable domain blocklists via the
/api/v1/admin/domain_blocksendpoint.A list of domains should be a json-formatted file that looks like this:
To import a list of domain blocks:
curl -H 'Authorization: Bearer SOME_BEARER_TOKEN' -X POST -F domains=@./domains.json https://your.instance.host/api/v1/admin/domain_blocks?import=trueDomain blocks in the file will then be created one-by-one, with the side effects processed asynchronously.
This was tested by uploading a list of ~700 domains taken from the rage.love blocklist, and the upload and initialization of blocking side effects took ~8-10 seconds.
This PR also ensures that domain blocks can be deleted, and accounts that were suspended as part of the deleted domain block will be unsuspended correctly.