Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding request parameter #8

Conversation

banakemi
Copy link

パラメーターの下記を修正

  • IPの追加
  • sdkTypeをdeviceにあわせた
  • appname or appbundleの追加
  • advertising_id or idfaの追加

@banakemi banakemi requested a review from nabata October 20, 2021 09:01
@banakemi banakemi self-assigned this Oct 20, 2021
@banakemi banakemi requested a review from NaoOishi October 20, 2021 09:02
Copy link

@NaoOishi NaoOishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@nabata nabata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@banakemi banakemi merged commit 0719de6 into feature/update-adgeneration1.0.3 Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants