Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

touchgift_delivery_dataテーブルにいれる値の修正 #22

Merged
merged 2 commits into from
Oct 4, 2024
Merged

touchgift_delivery_dataテーブルにいれる値の修正 #22

merged 2 commits into from
Oct 4, 2024

Conversation

s-hosomi
Copy link
Contributor

@s-hosomi s-hosomi commented Oct 3, 2024 •
edited
Loading

概要

  • キャンペーン開始時にDynamoDBのtouchgift_delivery_dataテーブルにNFC情報がすべて入るはずが、現状1件しか登録されない問題の修正
  • 合わせて、store_idもdeliveryテーブルに入るように修正

@s-hosomi s-hosomi changed the title delivery_dataにstore_idを追加 touchgift_delivery_dataテーブルにいれる値の修正 Oct 3, 2024
NaoyukiGouko
NaoyukiGouko approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@NaoyukiGouko NaoyukiGouko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードは問題ないと思うのでApproveします。CIが失敗しているのでそちらご確認お願いします。

@s-hosomi s-hosomi merged commit 1653b91 into beta/feature/1.0.0 Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaoyukiGouko NaoyukiGouko NaoyukiGouko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-hosomi @NaoyukiGouko