Update http dependency #36
Conversation
| @@ -16,8 +16,8 @@ environment: | |||
| dependencies: | |||
| flutter: | |||
| sdk: flutter | |||
| http: ^0.13.0 | |||
There was a problem hiding this comment.
Would be better to leave the upper bound at 1.1.0 instead. It is the current stable release and 1.2 could have breaking changes that will cause issues if the SuperTokens SDK is not compatible with it when it comes out
There was a problem hiding this comment.
Hey I am not sure I understand the upperbound is <1.2.0, which means that any hotfix in 1.1.X will still be compatible; but 1.2.0 will require a new check from the supertokens package
There was a problem hiding this comment.
Also @nkshah2 if they did release a breaking change, wouldn't that go to 2.0 instead of 1.2 (for the http lib)?
There was a problem hiding this comment.
@DwayneCoussement Youre right, I think we should still keep the lower bound to 0.13 to not force users to have to update
|
Thanks for the PR, added a quick comment and ill be happy to merge after that is resolved. Also please change the target branch of your pull request to be 0.2 |
| @@ -16,8 +16,8 @@ environment: | |||
| dependencies: | |||
| flutter: | |||
| sdk: flutter | |||
| http: ^0.13.0 | |||
There was a problem hiding this comment.
@DwayneCoussement Youre right, I think we should still keep the lower bound to 0.13 to not force users to have to update
pubspec.yaml
Outdated
| http: ^0.13.0 | ||
| shared_preferences: ^2.0.0 | ||
| http: ">=1.0.0 <1.2.0" | ||
| shared_preferences: ^2.2.0 |
There was a problem hiding this comment.
2.1.0 made the minimum flutter sdk version required to be 3.3. I'd still like to support SDK version 3.0. maybe we make this >=2.0.0 <3.0.0?
There was a problem hiding this comment.
versions have been updated @nkshah2 👍
Summary of change
Just updates the http dependency so users can keep updating their http library and third party dependencies as well (think about firebase for example).