Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for system Bullet #5048

Closed
wants to merge 1 commit into from

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Apr 8, 2024

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

@qwertychouskie
Copy link
Contributor

Using system Bullet is not an option, see #5035 (comment)

@eli-schwartz
Copy link

This pull request doesn't contain any version matching to ensure that the correct version of bullet is used. In theory the objections from the linked ticket could could be answered via requiring specific versions or else mandating the bundled copy

While I would absolutely appreciate support for a system copy too, I think it's extremely important to collaborate with upstream's concerns that "just any version" will produce incorrect results.

@qwertychouskie
Copy link
Contributor

This pull request doesn't contain any version matching to ensure that the correct version of bullet is used. In theory the objections from the linked ticket could could be answered via requiring specific versions or else mandating the bundled copy

While I would absolutely appreciate support for a system copy too, I think it's extremely important to collaborate with upstream's concerns that "just any version" will produce incorrect results.

Even "the exact same version" wouldn't work, as STK's Bullet has had modifications made over the years, including changes to functionality.

https://github.com/supertuxkart/stk-code/commits/master/lib/bullet

@ognevny ognevny closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants