Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace std::random_shuffle with std::shuffle #5145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nyllet
Copy link
Contributor

@nyllet nyllet commented Aug 9, 2024

std::random_shuffle was removed in c++17

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

std::random_shuffle was removed in c++17
@CodingJellyfish
Copy link
Member

Should it use mt19937? From what I know it has no benefit other than a much longer cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants