Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3 spaces for consistency with other strings #5274

Closed

Conversation

scootergrisen
Copy link
Contributor

@scootergrisen scootergrisen commented Jan 25, 2025

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

For consistency with other strings.

Both of these exists I'm just removing the one with the extra space:

Locked: solve active challenges to gain access to more!" without space already exists.
Locked : solve active challenges to gain access to more!" without space already exists.

@CodingJellyfish
Copy link
Member

Sorry it will break translation string.

@scootergrisen
Copy link
Contributor Author

That was the whole point.
I saw them in the translation and want to improve it.

Both of these exists I'm just removing the one with the extra space:

Locked: solve active challenges to gain access to more!" without space already exists.
Locked : solve active challenges to gain access to more!" without space already exists.

@CodingJellyfish
Copy link
Member

I'm very sorry about my arbitrariness. You may put the agreement part back to the description and then I'll merge.

@scootergrisen scootergrisen changed the title Remove 3 spaces Remove 3 spaces for consistency with other strings Jan 27, 2025
@scootergrisen
Copy link
Contributor Author

How about now?
Not sure what you mean by agreement part.

@Alayan-stk-2
Copy link
Collaborator

How about now? Not sure what you mean by agreement part.

Read the text that's in a new PR's text field before deleting it...

Both of these exists I'm just removing the one with the extra space:

Both exist for the locked one, but not for the anti-aliasing off. Of course, this last one also ought to be corrected, but doing it now would mean having to go over all the translations that had the previous string and fixing them. Not great soon before a release.

@scootergrisen
Copy link
Contributor Author

Translators might be used to strings being changed so i dont consider it a big deal changing already translated strings.
And I don't think you have to do a search/replace in the translations to help out the poor translatons so 30 translators don't have to translate the string again.
It's what translators do.
If they know the translations and know how to use tools like Transifex it's easy. They can look at the differences between the old and new source string and copy the old translation and remove the space. It don't take much time.

@Alayan-stk-2
Copy link
Collaborator

You assume, incorrectly, that translators for all relevant languages will check on the status of translations before the next release. The changes are easy to do, but you need someone to do them. Breaking strings after a string freeze is problematic. The only way this doesn't break translation for multiple languages is me going to manually update it.

@scootergrisen
Copy link
Contributor Author

Ok just forgot about it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants