-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3 spaces for consistency with other strings #5274
Remove 3 spaces for consistency with other strings #5274
Conversation
Sorry it will break translation string. |
That was the whole point. Both of these exists I'm just removing the one with the extra space:
|
I'm very sorry about my arbitrariness. You may put the agreement part back to the description and then I'll merge. |
How about now? |
Read the text that's in a new PR's text field before deleting it...
Both exist for the locked one, but not for the anti-aliasing off. Of course, this last one also ought to be corrected, but doing it now would mean having to go over all the translations that had the previous string and fixing them. Not great soon before a release. |
Translators might be used to strings being changed so i dont consider it a big deal changing already translated strings. |
You assume, incorrectly, that translators for all relevant languages will check on the status of translations before the next release. The changes are easy to do, but you need someone to do them. Breaking strings after a string freeze is problematic. The only way this doesn't break translation for multiple languages is me going to manually update it. |
Ok just forgot about it then. |
Agreement
For consistency with other strings.
Both of these exists I'm just removing the one with the extra space: