Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language - variable name spelling mistake #823

Closed
garp5000 opened this issue Aug 11, 2017 · 4 comments
Closed

Language - variable name spelling mistake #823

garp5000 opened this issue Aug 11, 2017 · 4 comments

Comments

@garp5000
Copy link

Hello,

this wasn't a bug but just a little spelling mistake on a variable name in the files :

  • appresource.properties
  • appresource_ja.properties
    They're a variable named "knowledge.auth.label.request.init.passwoed", I think the right name should be "knowledge.auth.label.request.init.password"

By the case, you made a very good job, all seems to be very clean and pleasant to read! Thank you!

@garp5000
Copy link
Author

Hello again,

I've found another one, the variable named "knowledge.auth.label.request.init.passwoed" instead of "knowledge.auth.label.request.init.password".

Another thing, when we edit a knowledge, I see the label "draft delete" doesn't have his self variable but is create by associate "label.draft" with "label.delete". Do you think it's possible to give him a full variable? (for exemple: label.draftdelete).

Thanks.

@koda-masaru
Copy link
Contributor

koda-masaru commented Aug 12, 2017

Hi,

Thank you for your advice for typo. I will fix it.
Also, if you are not troubled, please send a pull request as well.

And I will change a button label label.draft & label.delete to label.delete.draft on the edit page.

Regards.

@koda-masaru koda-masaru added this to the v1.11 milestone Aug 12, 2017
koda-masaru added a commit that referenced this issue Aug 12, 2017
…nowledge.auth.label.request.init.password".
koda-masaru added a commit that referenced this issue Aug 12, 2017
@garp5000
Copy link
Author

Thank you very much !

Best regards,

@koda-masaru
Copy link
Contributor

This is fixed by v1.11.0.
I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants