Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Session.render() #263

Closed
josiah-wolf-oberholtzer opened this issue Aug 26, 2022 · 3 comments
Closed

Simplify Session.render() #263

josiah-wolf-oberholtzer opened this issue Aug 26, 2022 · 3 comments
Assignees

Comments

@josiah-wolf-oberholtzer
Copy link
Contributor

The renderable dependency graph system is cool, and was a great learning experience, but in practice it's much too complex for most use cases.

We can simplify Session.render() so that it supports all common use-cases:

  • Render a session to an output file
  • Render a session but without an output file (e.g. generating analysis as a side-effect)
  • Render a session with an input file and an output file
  • Render a session but with all audio files (input/output/buffers) referenced as relative paths

More complex dependency graph logic can be reimplemented on top of a simpler render system.

@josiah-wolf-oberholtzer
Copy link
Contributor Author

The multiple-renders-in-one approach might still be feasible, but:

  • The path handling inside SessionRenderer should be rewritten because it's very confusing
  • The render.yml output has never seen use and should be removed
  • Renders should default to a temp directory as their render directory

@josiah-wolf-oberholtzer
Copy link
Contributor Author

Writing to /dev/null (on Linux/OSX) and NUL (on Windows) should be made simple.

@josiah-wolf-oberholtzer
Copy link
Contributor Author

Done in #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant