-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor NRT rendering #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderables (classes implementing
__render__
) should now use the signature:... returning a 2-tuple of:
... or a zero-argument callable that results in that 2-tuple (which makes rendering online buffers in Supriya's Sphinx documentation possible given that the buffer is offline by the time the HTML is rendered out).
While this is a kind of tricky-interface, it really simplifies the internals of
Session
-rendering. Sessions can now determine the expected output paths of all renderables in their dependency graph before anything is rendered, and can perform rendering asynchronously.Sessions can now also be rendered with their output suppressed, e.g. sent to
/dev/null
(orNUL
on Windows), which greatly simplifies doing offline analysis where the only desired output is from a manually-written buffer.