migrate scoreboard to imgui tables api (1.8+) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping to something that is supported and receives bugfixes and features
+ and Ability to sort playerlist however you like as a treat, i guess
Regressions
scoreboard won't grow over and "take over" the logs window.
honestly I might just keep that behavior. if you want to not see logs window just go to view -> uncheck logs window.
Limitations
I only migrated scoreboard there are some things that use the old column api but later lazy
Other Notes
may fix #24
we can now start working on #27 (just have an option to disable the sorting if mouseover)