Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNP-1424 removed defaultSignals variable #10

Merged
merged 1 commit into from
Jul 1, 2024
Merged

SNP-1424 removed defaultSignals variable #10

merged 1 commit into from
Jul 1, 2024

Conversation

Goldilocks97
Copy link
Contributor

Что сделано

  • удалена переменная defaultSignals из макроса, так как теперь во флоу не существует внутренних сигналов модуля => нет необходимости в переменной

Как проверить

  • запустить тесты

@Goldilocks97 Goldilocks97 requested a review from NullIsOne June 28, 2024 08:53
@Goldilocks97 Goldilocks97 self-assigned this Jun 28, 2024
NullIsOne
NullIsOne approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@NullIsOne NullIsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо будет кстати тесты на github actions хотябы тут затянуть.

Вызова swift test должно быть достаточно.
Тесты макроса используют macOS таргет, так что должно сработать.

@NullIsOne NullIsOne merged commit 0e268d3 into main Jul 1, 2024
@NullIsOne NullIsOne deleted the SNP-1424-multicast-macro-improvments branch July 1, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullIsOne NullIsOne NullIsOne approved these changes

Assignees

@Goldilocks97 Goldilocks97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goldilocks97 @NullIsOne