Find single characters rather than single character strings. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused variable.
baconpaul
reviewed
Nov 19, 2024
| @@ -29,7 +29,6 @@ inline std::istream &getlineEndingIndependent(std::istream &is, std::string &t) | |||
| { | |||
| t.clear(); | |||
|
|
|||
There was a problem hiding this comment.
Ooooh removing the sentry is not correct. Thats a guard class which sets internal bits
There was a problem hiding this comment.
@baconpaul
OK, so perhaps the fix should be to test the sentry object is valid after construction?
That way it wouldn't be flagged as unused by an analyser.
There was a problem hiding this comment.
@baconpaul See what you think of the latest commit.
Minor changes to Tuning::Tuning: Use actual type rather than auto because modern tools will warn that the auto probably ought to be a reference, but in this case a copy is clearly needed. Move pitches array closer to usage.
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variable.