Support end-of-line comments in scl files #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some scl files which use end-of-line comments on each ratio, for example septenariusGG49.scl from the Scala scale archive:
At the moment a
.
in the comment causes the line to be interpreted as a cent value, which can give unexpected results. For example for septenariusGG49.scl, the line555/524 ! c# 138.75 Hz
is currently given a cent value of555.0
- I've attached a screenshot from the Surge tuning editor:The scl files in the Scala scale archive which give unexpected results for this reason are:
There's also some cases from the tuning mailing list, for example here, here, and here.
I made a local tuning-library change to handle end-of-line comments so I thought I'd make a PR with it in case it's useful.