feat(http/1): handles the case where the declared content length is l…

…ess than what is sent
suri-framework · Jan 3, 2024 · 3071a81 · 3071a81
1 parent 20189db
commit 3071a81
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/test/bandit/test/bandit/http1/request_test.exs b/test/bandit/test/bandit/http1/request_test.exs
@@ -575,7 +575,7 @@ defmodule HTTP1RequestTest do
         "POST /error_catcher HTTP/1.1\r\nhost: localhost\r\ncontent-length: 3\r\n\r\nABCDE"
       )
 
-      assert {:ok, "200 OK", _, "excess_body_read"} = SimpleHTTP1Client.recv_reply(client)
+      assert {:ok, "200 OK", _, "Excess_body_read"} = SimpleHTTP1Client.recv_reply(client)
     end
 
     test "reading request body multiple times works as expected", context do

diff --git a/test/http_test.ml b/test/http_test.ml
@@ -151,7 +151,13 @@ module Test : Application.Intf = struct
           let[@warning "-8"] (Conn.Error (conn, reason)) =
             Conn.read_body conn
           in
-          let body = Format.asprintf "%a" IO.pp_err reason in
+          let body =
+            match reason with
+            | `Excess_body_read -> "Excess_body_read"
+            | ( `Closed | `Process_down | `Timeout
+              | `Unix_error _ ) as reason ->
+                Format.asprintf "%a" IO.pp_err reason
+          in
           conn |> Conn.send_response `OK ~body
       | _ ->
           let[@warning "-8"] (Conn.Ok (conn, body)) = Conn.read_body conn in
@@ -165,7 +171,7 @@ module Test : Application.Intf = struct
       ~transport:
         Atacama.Transport.(
           tcp
-            ~config:{ receive_timeout = 1_000_000L; send_timeout = 1_000_000L }
+            ~config:{ receive_timeout = 5_000_000L; send_timeout = 5_000_000L }
             ())
       ~config:
         (Nomad.Config.make ~max_header_count:40 ~max_header_length:5000 ())