Add tests, set permission default constants

surminus · Aug 14, 2023 · aacbd6b · aacbd6b
1 parent b48ed4a
commit aacbd6b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/resources/directory_test.go b/resources/directory_test.go
@@ -31,6 +31,7 @@ func TestDirectory(t *testing.T) {
  assert.NoError(t, err)
 
  assert.Equal(t, true, viaduct.DirExists(d.Path))
+ assert.Equal(t, true, viaduct.MatchChmod(d.Path, DefaultDirectoryPermissions))
 
  err = os.RemoveAll(d.Path)
  if err != nil {

diff --git a/resources/file_test.go b/resources/file_test.go
@@ -34,6 +34,7 @@ func TestFile(t *testing.T) {
  assert.NoError(t, err)
 
  assert.Equal(t, true, viaduct.FileExists(f.Path))
+ assert.Equal(t, true, viaduct.MatchChmod(f.Path, DefaultFilePermissions))
  assert.Equal(t, f.Content, viaduct.FileContents(f.Path))
 
  err = os.Remove(f.Path)

diff --git a/resources/git_test.go b/resources/git_test.go
@@ -34,6 +34,7 @@ func TestGit(t *testing.T) {
  assert.NoError(t, err)
 
  assert.Equal(t, true, viaduct.DirExists(filepath.Join(g.Path, ".git")))
+ assert.Equal(t, true, viaduct.MatchChmod(g.Path, DefaultDirectoryPermissions))
 
  // Use the same test for cloning and deleting so we don't waste time
  // cloning twice

diff --git a/resources/utils.go b/resources/utils.go
@@ -2,6 +2,7 @@ package resources
 
 import (
  "fmt"
+ "io/fs"
  "os"
  "os/user"
  "strconv"
@@ -33,14 +34,19 @@ const (
  pfile ptype = "file"
 )
 
+const (
+ DefaultDirectoryPermissions fs.FileMode = os.ModeDir | 0o755
+ DefaultFilePermissions fs.FileMode = 0o644
+)
+
 func (p *permissions) preflightPermissions(t ptype) error {
  if p.Mode == 0 {
  if t == pdir {
- p.Mode = os.ModeDir | 0755
+ p.Mode = DefaultDirectoryPermissions
  }
 
  if t == pfile {
- p.Mode = 0o644
+ p.Mode = DefaultFilePermissions
  }
  } else {
  if t == pdir {