improve export reliability

src/adapter/browser.tsx

@@ -121,12 +121,12 @@ export class BrowserAdapter implements SurrealistAdapter {
 		_title: string,
 		defaultPath: string,
 		_filters: any,
-		content: () => Result<string | Blob | null>,
+		content: () => Result<string | Blob>,
 	): Promise<boolean> {
 		const result = await content();
 
 		if (!result) {
-			return false;
+			throw new Error("File is empty");
 		}
 
 		const file =
@@ -252,7 +252,7 @@ export class BrowserAdapter implements SurrealistAdapter {
 			config.connectionGroups.push({
 				id: INSTANCE_GROUP,
 				name: instanceConfig.groupName,
-				collapsed: instanceConfig.groupCollapsed
+				collapsed: instanceConfig.groupCollapsed,
 			});
 		}
 

src/adapter/desktop.tsx

@@ -195,7 +195,7 @@ export class DesktopAdapter implements SurrealistAdapter {
 		const result = await content();
 
 		if (!result) {
-			return false;
+			throw new Error("File is empty");
 		}
 
 		if (typeof result === "string") {

src/components/App/modals/data-export.tsx

@@ -15,7 +15,7 @@ import { useIntent } from "~/hooks/routing";
 import { useTableNames } from "~/hooks/schema";
 import { useStable } from "~/hooks/stable";
 import { requestDatabaseExport } from "~/screens/surrealist/connection/connection";
-import { showInfo, slugify } from "~/util/helpers";
+import { showError, showInfo, slugify } from "~/util/helpers";
 import { iconDownload } from "~/util/icons";
 import { syncConnectionSchema } from "~/util/schema";
 
@@ -60,16 +60,21 @@ export function DataExportModal() {
 				[SURQL_FILTER],
 				async () => {
 					setIsExporting(true);
-					return (await requestDatabaseExport(config)) ?? null;
+					return requestDatabaseExport(config);
 				},
 			);
 
 			if (success) {
 				showInfo({
 					title: "Export",
-					subtitle: "Database export successfully created",
+					subtitle: "Database successfully exported",
 				});
 			}
+		} catch (err: any) {
+			showError({
+				title: "Export failed",
+				subtitle: err.message,
+			});
 		} finally {
 			setIsExporting(false);
 			openedHandle.close();

src/screens/surrealist/connection/connection.tsx

@@ -636,11 +636,7 @@ export async function requestDatabaseExport(config?: ExportOptions) {
 	const useModern = compareVersions(version, "2.1.0");
 
 	if (!connection || currentState !== "connected") {
-		showError({
-			title: "Failed to export",
-			subtitle: "You must be connected to the remote instance",
-		});
-		return;
+		throw new Error("Not connected to an instance");
 	}
 
 	if (useModern) {