Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add versioned iterator #31

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Feat/add versioned iterator #31

merged 5 commits into from
Jun 25, 2024

Conversation

arriqaaq
Copy link
Contributor

@arriqaaq arriqaaq commented Jun 25, 2024 •
edited
Loading

Description

This PR adds the following

  • A versioned iterator to traverse over all the versions for a given key
  • A versioned range scan iterator to traverse over all the versions for the keys in the range
  • Fix bug where non existing key doesn't set root to none in remove method

@arriqaaq arriqaaq force-pushed the feat/add-versioned-iterator branch from 3f043ba to adf1d94 Compare June 25, 2024 03:33
@arriqaaq arriqaaq force-pushed the feat/add-versioned-iterator branch from adf1d94 to 7e08fe4 Compare June 25, 2024 04:05
emmanuel-keller
emmanuel-keller approved these changes Jun 25, 2024
View reviewed changes
Copy link

@emmanuel-keller emmanuel-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome Versioned Iterator!

@tobiemh
Copy link
Member

tobiemh commented Jun 25, 2024

😄

@arriqaaq
Copy link
Contributor Author

Thank you @emmanuel-keller !

@arriqaaq arriqaaq merged commit 6de61e5 into main Jun 25, 2024
1 check passed
@arriqaaq arriqaaq deleted the feat/add-versioned-iterator branch June 25, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuel-keller emmanuel-keller emmanuel-keller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arriqaaq @tobiemh @emmanuel-keller