Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add versioned apis #33

Merged
merged 14 commits into from
Jul 3, 2024
Merged

chore: add versioned apis #33

merged 14 commits into from
Jul 3, 2024

Conversation

arriqaaq
Copy link
Contributor

@arriqaaq arriqaaq commented Jul 2, 2024

Description

This PR does the following

  1. Adds the following versioned APIs to the snapshot and tree
    • get_at_ts (to get a key at a particular timestamp)
    • get_all_versions (to get all the versions of a key)
    • scan_at_ts (scans all keys at a timestamp)
    • keys_at_ts (query all keys at a timestamp)
  2. Avoid returning the key from all the get APIs
  3. Shorten function name insert_without_version_increment_check ---> insert_unchecked
  4. Fix an issue with duplicate insertion (two keys with the same version) into the twig node, where the duplicate node is not sorted by timestamp
  5. Add get_value_by_query to both tree and snapshot to query the value by the following query types
    • LatestByVersion
    • LatestByTs
    • LastLessThanTs
    • LastLessOrEqualTs
    • FirstGreaterThanTs
    • FirstGreaterOrEqualTs

@arriqaaq arriqaaq force-pushed the chore/add-versioned-apis branch from 203b26e to 87f799c Compare July 3, 2024 04:49
@arriqaaq arriqaaq force-pushed the chore/add-versioned-apis branch from d1f4722 to 915a109 Compare July 3, 2024 08:21
@arriqaaq arriqaaq force-pushed the chore/add-versioned-apis branch from bc28148 to d4f7c87 Compare July 3, 2024 08:37
@arriqaaq arriqaaq requested a review from gsserge July 3, 2024 08:42
Copy link
Contributor

@gsserge gsserge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arriqaaq arriqaaq merged commit c7504f3 into main Jul 3, 2024
1 check passed
@arriqaaq arriqaaq deleted the chore/add-versioned-apis branch July 3, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants