Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the newest tabulator version and remove datatables #297

Merged
merged 12 commits into from
Jan 16, 2025
5 changes: 2 additions & 3 deletions examples/tabulator.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@

<link rel="stylesheet" type="text/css" href="../node_modules/tabulator-tables/dist/css/tabulator.css" />
<link rel="stylesheet" type="text/css" href="../packages/survey.analytics.tabulator.css" />
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jspdf/1.5.3/jspdf.min.js"></script>
<script type="text/javascript"
src="https://cdnjs.cloudflare.com/ajax/libs/jspdf-autotable/3.0.10/jspdf.plugin.autotable.min.js"></script>
<script src="https://unpkg.com/jspdf@2.4.0/dist/jspdf.umd.min.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jspdf-autotable/3.5.20/jspdf.plugin.autotable.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
<script type="text/javascript" src="https://oss.sheetjs.com/sheetjs/xlsx.full.min.js"></script>
<script src="../node_modules/tabulator-tables/dist/js/tabulator.js"></script>
<script src="../node_modules/survey-core/survey.core.js"></script>
Expand Down
9,207 changes: 4,979 additions & 4,228 deletions package-lock.json

Large diffs are not rendered by default.

17 changes: 2 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"build:prod": "npm run build:dev && webpack --env buildType=prod",
"build": "npm run build:prod",
"build:types:summary": "tsc --p tsconfig.summary.json && echo \"export * from './survey-analytics.types/entries/summary';\" >> packages/survey.analytics.d.ts",
"build:types:datatables": "tsc --p tsconfig.datatables.json && echo \"export * from './survey-analytics-datatables.types/entries/datatables';\" >> packages/survey.analytics.datatables.d.ts",
"build:types:tabulator": "tsc --p tsconfig.tabulator.json && echo \"export * from './survey-analytics-tabulator.types/entries/tabulator';\" >> packages/survey.analytics.tabulator.d.ts",
"lint": "eslint ./src --quiet",
"pre-push-check": "npm run lint && npm run test"
Expand Down Expand Up @@ -43,23 +42,11 @@
"homepage": "https://surveyjs.io/",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"datatables.net": "^1.11.5",
"datatables.net-buttons": "^1.7.1",
"datatables.net-buttons-dt": "^1.7.1",
"datatables.net-colreorder": "^1.5.5",
"datatables.net-colreorder-dt": "^1.5.5",
"datatables.net-dt": "^1.11.5",
"datatables.net-responsive": "^2.2.9",
"datatables.net-responsive-dt": "^2.2.9",
"datatables.net-rowgroup": "^1.1.4",
"datatables.net-rowgroup-dt": "^1.1.4",
"datatables.net-select": "^1.3.4",
"datatables.net-select-dt": "^1.3.4",
"jquery": "3.5.0",
"muuri": "^0.8.0",
"plotly.js-dist-min": "^2.28.0",
"survey-core": "latest",
"tabulator-tables": "4.8.4"
"tabulator-tables": "^6.2.5"
},
"devDependencies": {
"@types/jest": "^26.0.24",
Expand Down Expand Up @@ -109,4 +96,4 @@
"pre-push": "npm run pre-push-check"
}
}
}
}
26 changes: 0 additions & 26 deletions src/entries/datatables.ts

This file was deleted.

1 change: 0 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export * from "./visualizationMatrixDynamic";
export * from "./visualizationMatrixDropdown";
export * from "./alternativeVizualizersWrapper";

export * from "./tables/datatables";
export * from "./tables/tabulator";

export * from "./plotly/index";
Expand Down
154 changes: 0 additions & 154 deletions src/tables/datatables.scss

This file was deleted.

Loading
Loading