Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-place editing: Question actions appear incorrectly on the design surface #4354

Closed
2 tasks
JaneSjs opened this issue Jul 24, 2023 · 2 comments · Fixed by #4524
Closed
2 tasks

In-place editing: Question actions appear incorrectly on the design surface #4354

JaneSjs opened this issue Jul 24, 2023 · 2 comments · Fixed by #4524
Assignees
@mikeamelin @novikov82
Labels
bug
Milestone
v1.9.106

Comments

@JaneSjs
Copy link
Contributor

JaneSjs commented Jul 24, 2023 •
edited
Loading

View Demo
To reproduce the issue, decrease the width of a question so that actions cannot fit into the action bar:
image

The following issues appear:

  • A question's menu popup diesn't display item captions:
    image

  • A question type selector dropdown arrow is duplicated and appears at an incorrect position:
    image
@JaneSjs JaneSjs added the bug label Jul 24, 2023
@mikeamelin
Copy link

Related issues — https://github.com/surveyjs/private-tasks/issues/250

@mikeamelin
Copy link

Prototype — https://www.figma.com/file/jcuAUsN02n2yJerx39mqf9/Previews?type=design&node-id=423-337200&mode=design

@novikov82 novikov82 self-assigned this Aug 15, 2023
novikov82 added a commit that referenced this issue Aug 28, 2023
@novikov82
#4354 Inplace Editing - Question actions appear incorrectly when a qu…
d6ed0c5 
…estion's design area

Fixes #4354
novikov82 added a commit that referenced this issue Aug 29, 2023
@novikov82
#4354 hide subtype
0c3bbbb 
Fixes #4354
novikov82 added a commit that referenced this issue Aug 29, 2023
@novikov82
#4354 Inplace Editing - Question actions appear incorrectly when a qu…
8881275 
…estion's design area

Fixes #4354
novikov82 pushed a commit that referenced this issue Aug 29, 2023
update adaptivity params and styles #4354
fb85647
novikov82 added a commit to surveyjs/survey-library that referenced this issue Aug 30, 2023
@novikov82
adaptivity enhancements
8ee1035 
need for surveyjs/survey-creator#4354
This was referenced Aug 30, 2023
Merged
Merged
novikov82 added a commit that referenced this issue Aug 30, 2023
@novikov82
#4354 Inplace Editing - Question actions appear incorrectly when a qu…
da63dcb 
…estion's design area

Fixes #4354
novikov82 added a commit that referenced this issue Aug 30, 2023
@novikov82
#4354 - observability and tests
35f5e47
tsv2013 pushed a commit to surveyjs/survey-library that referenced this issue Aug 30, 2023
@novikov82
Adaptive container enhancements (#6833)
f619bc3 
* adaptive-container-enhancements

* add hideFirst option

* fixed action item remove priority

* adaptivity enhancements
need for surveyjs/survey-creator#4354

* fixed markup etalons

---------

Co-authored-by: Aleksey Novikov <novikov@abrisplatform.com>
novikov82 pushed a commit that referenced this issue Aug 30, 2023
#4354 - fixed button paddings
815cde6
novikov82 added a commit that referenced this issue Aug 31, 2023
@novikov82
#4354 fixed styles
d33afbc 
Fixes #4354
novikov82 pushed a commit that referenced this issue Aug 31, 2023
#4354 - fix test
4c46f02
andrewtelnov pushed a commit that referenced this issue Sep 1, 2023
@novikov82
Issue/4354-Inplace-Editing---Question-actions-appear-incorrectly-when…
d52a3ab 
…-a-questions-design-area (#4524)

* #4354 Inplace Editing - Question actions appear incorrectly when a question's design area
Fixes #4354

* #4354 hide subtype
Fixes #4354

* #4354 Inplace Editing - Question actions appear incorrectly when a question's design area
Fixes #4354

* update adaptivity params and styles   #4354

* #4354 Inplace Editing - Question actions appear incorrectly when a question's design area
Fixes #4354

* #4354 - observability and tests

* #4354 - fixed button paddings

* #4354 fixed styles
Fixes #4354

* update screenshots

* #4354 - fix test

* update tests

---------

Co-authored-by: Aleksey Novikov <novikov@abrisplatform.com>
@OlgaLarina OlgaLarina added this to the v1.9.106 milestone Sep 5, 2023
@RomanTsukanov RomanTsukanov changed the title Inplace Editing - Question actions appear incorrectly when a question's design area In-place editing: Question actions appear incorrectly on the design surface Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeamelin mikeamelin

@novikov82 novikov82

Labels
bug
Projects
None yet
Milestone
v1.9.106
5 participants
@tsv2013 @OlgaLarina @mikeamelin @JaneSjs @novikov82