Work for surveyjs/survey-creator#4484 - memory leaks in survey creato…

…r - reset list container element ref
surveyjs · Aug 29, 2023 · f664775 · f664775
1 parent 5476b19
commit f664775
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/knockout/components/list/list.ts b/src/knockout/components/list/list.ts
@@ -17,7 +17,10 @@ ko.components.register("sv-list", {
       model.initListContainerHtmlElement(componentInfo.element);
       return {
         model: model,
-        dispose: () => { _implementor.dispose(); },
+        dispose: () => {
+          _implementor.dispose();
+          model.initListContainerHtmlElement(undefined as any);
+        },
         afterItemRender: (_: any, action: Action) => {
           !!ko.tasks && ko.tasks.runEarly();
           model.onLastItemRended(action);

diff --git a/src/react/components/list/list.tsx b/src/react/components/list/list.tsx
@@ -37,6 +37,12 @@ export class List extends SurveyElementBase<IListProps, any> {
       this.model.initListContainerHtmlElement(this.listContainerRef.current);
     }
   }
+  componentWillUnmount(): void {
+    super.componentWillUnmount();
+    if(!!this.model) {
+      this.model.initListContainerHtmlElement(undefined as any);
+    }
+  }
   renderElement() {
     return (
       <div className={this.model.cssClasses.root} ref={this.listContainerRef}>