Merge pull request #3146 from surveyjs/feature/issue-3145-setValue

Fix: Clear setValue for setvalue trigger can produce exception #3145
surveyjs · Jul 29, 2021 · f831d1c · f831d1c
2 parents b938b6d + e2efee1
commit f831d1c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/base.ts b/src/base.ts
@@ -368,7 +368,7 @@ export class Base {
    */
   public setPropertyValue(name: string, val: any) {
     var oldValue = this.getPropertyValue(name);
-    if (oldValue && Array.isArray(oldValue)) {
+    if (oldValue && Array.isArray(oldValue) && !!this.arraysInfo) {
       if (this.isTwoValueEquals(oldValue, val)) return;
       var arrayInfo = this.arraysInfo[name];
       this.setArray(

diff --git a/tests/basetests.ts b/tests/basetests.ts
@@ -484,3 +484,10 @@ QUnit.test("Base onArrayChanged", function(assert) {
   assert.equal(arrayChanges.index, 0, "added into 0 index");
   assert.deepEqual(arrayChanges.itemsToAdd, [base.items[0]], "added items");
 });
+QUnit.test("Change value to array and then to undefined", function(assert) {
+  var base = new Base();
+  base.setPropertyValue("testValue", [1, 2, 3]);
+  assert.deepEqual(base.getPropertyValue("testValue"), [1, 2, 3]);
+  base.setPropertyValue("testValue", undefined);
+  assert.notOk(base.getPropertyValue("testValue"));
+});