Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Single matrix columns are not updated on changing if matrix is editing in property grid #3027

Closed
andrewtelnov opened this issue Jun 27, 2021 · 0 comments
Closed

React: Single matrix columns are not updated on changing if matrix is editing in property grid #3027

andrewtelnov opened this issue Jun 27, 2021 · 0 comments
Labels
bug
Milestone
v1.8.54

Comments

@andrewtelnov
Copy link
Member

The bug was found on testing SurveyJS Creator V2, react version, React: Matrix (single choice) doesn't update after add/remove columns.
Property grid overrides columns onArrayChanged callback, however it doesn't need this callback.
@andrewtelnov andrewtelnov added this to the v1.8.54 milestone Jun 27, 2021
andrewtelnov added a commit that referenced this issue Jun 27, 2021
@andrewtelnov
Fix: (React) Single matrix columns are not updated on changing if mat…
5a9f7bc 
…rix is editing in property grid #3027
@andrewtelnov andrewtelnov mentioned this issue Jun 27, 2021
Merged
tsv2013 pushed a commit that referenced this issue Jun 28, 2021
@andrewtelnov
Fix: (React) Single matrix columns are not updated on changing if mat…
e5a87a0 
…rix is editing in property grid #3027 (#3028)
andrewtelnov added a commit that referenced this issue Jun 28, 2021
@andrewtelnov
Change the fix, re-write the code, due breacking e2e tests, #3027
ba1cf8f
tsv2013 pushed a commit that referenced this issue Jun 28, 2021
@andrewtelnov
Change the fix, re-write the code, due breacking e2e tests, #3027 (#3029
5625620 
)
andrewtelnov added a commit that referenced this issue Jun 28, 2021
@andrewtelnov
Remove a static function, #3027
0b78e33
tsv2013 pushed a commit that referenced this issue Jun 28, 2021
@andrewtelnov
Remove a static function, #3027 (#3030)
6646c97
andrewtelnov added a commit that referenced this issue Jun 28, 2021
@andrewtelnov
Add and fix new unit test to fix unit tests in Creator v2, #3027
b5f71b6
tsv2013 pushed a commit that referenced this issue Jun 29, 2021
@andrewtelnov
Add and fix new unit test to fix unit tests in Creator v2, #3027 (#3032)
d81d7c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.8.54
Development

No branches or pull requests
1 participant
@andrewtelnov